-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fault filter: use correct stat prefix #251
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@lyft/network-team |
RomanDzhabarov
approved these changes
Nov 30, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'd probably need to have tests explicitly checking for stat name to catch that.
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* Templatize PathMatcher * make path_matcher.cc ready to move to header * Move path_matcher to independent build target * Remove utils from dep
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
mandarjog
pushed a commit
to mandarjog/envoy
that referenced
this pull request
Aug 14, 2020
* Add tests written using Proxy-Wasm Rust SDK. Signed-off-by: Piotr Sikora <[email protected]> * review: regenerated using published proxy-wasm crate. Signed-off-by: Piotr Sikora <[email protected]> * review: fix end_stream parameter in decodeHeaders(). Signed-off-by: Piotr Sikora <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: this PR adds a few foundational constructs to implement the c API introduced in #225. The approach take here is to create an Http dispatcher that is able to manage http streams via the APIs introduced in #225. The streams created by the dispatcher can be interacted with in the mobile platform, and ultimately map down to direct injection into the envoy router via upstream envoy constructs (async client, async stream, and the router). The code introduced here is capable of making a headers only request from platform code, and receiving the corresponding callback in platform code. Subsequent PRs will implement the other relevant methods to deal with data and trailers. Risk Level: med - foundational constructs introduced. Testing: added cpp unit tests, and a CI job to run them. Signed-off-by: Jose Nino <[email protected]> Co-authored-by: Mike Schore <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: this PR adds a few foundational constructs to implement the c API introduced in #225. The approach take here is to create an Http dispatcher that is able to manage http streams via the APIs introduced in #225. The streams created by the dispatcher can be interacted with in the mobile platform, and ultimately map down to direct injection into the envoy router via upstream envoy constructs (async client, async stream, and the router). The code introduced here is capable of making a headers only request from platform code, and receiving the corresponding callback in platform code. Subsequent PRs will implement the other relevant methods to deal with data and trailers. Risk Level: med - foundational constructs introduced. Testing: added cpp unit tests, and a CI job to run them. Signed-off-by: Jose Nino <[email protected]> Co-authored-by: Mike Schore <[email protected]> Signed-off-by: JP Simard <[email protected]>
arminabf
pushed a commit
to arminabf/envoy
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.